[Gecko Bug 1435658] Deal with appearance changes from / to none correctly.#145
Open
jgraham wants to merge 49 commits into
Open
[Gecko Bug 1435658] Deal with appearance changes from / to none correctly.#145jgraham wants to merge 49 commits into
jgraham wants to merge 49 commits into
Conversation
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1430622 gecko-commit: 2ea467872d7fcd3dbb31fcf881e4147b6dd6bebe gecko-integration-branch: autoland gecko-reviewers: xidorn, mats
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1303025 gecko-commit: 62f5c4a3682381134b607d359824b7605ec15156 gecko-integration-branch: autoland gecko-reviewers: bkelly
This is a partial revert of servo/servo@ce1d8cd If you're in a shadow tree, you may not be slotted but you still need to look at the slotted rules, since a <slot> could be a descendant of yours. Just use the same invalidation map everywhere, and remove complexity. This means that we can do some extra work while trying to gather invalidation if there are slotted rules, but I don't think it's a problem. The test is ported from https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/css/invalidation/slotted.html?l=1&rcl=58d68fdf783d7edde1c82a642e037464861f2787 Curiously, Blink fails the test as written, presumably because they don't flush styles from getComputedStyle correctly (in their test they do via updateStyleAndReturnAffectedElementCount), due to <slot>s not being in the flat tree in their implementation. bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1429846 gecko-commit: bec4537b2efd4f8381c5f398c71bc0f09d4da981 gecko-integration-branch: central gecko-reviewers: heycam
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1425458 gecko-commit: b96d58fd945ced9050f9b4602b9dfdf857d0954c gecko-integration-branch: mozilla-inbound gecko-reviewers: smaug
Behavior change: Certain unpaired high surrogates will result in the text being considered RTL where that wasn't the case before. bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1428774 gecko-commit: 1e903401fe835f02ccfefef39ffc2706d5a8c032 gecko-integration-branch: autoland gecko-reviewers: jfkthame
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1431814 gecko-commit: 4fe6b13848c8a9ab5897a5d9958e16d1eb83edd9 gecko-integration-branch: mozilla-inbound gecko-reviewers: asuth
The selectorText test happens to pass right now because well, we don't implement the setter yet[1], but would fail if we implemented an specific invalidation in the way I'd have done it yesterday. [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=37468 bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1432850 gecko-commit: e5ab5177f799a0d13a51db79e520a5db2cb08af7 gecko-integration-branch: central gecko-reviewers: bz
…at have anon boxes. bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1433591 gecko-commit: 30d915de546242961f2f3ce4e1cfbee5ec9e54bb gecko-integration-branch: central gecko-reviewers: bz
…allback behaviour, bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1409706 gecko-commit: 588fec4c25f558b4103de0302f41978010bbbe14 gecko-integration-branch: central gecko-reviewers: ckerschb
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1435658 gecko-commit: c074e2c4b2ed6c733479cad11204244edb9e51ef gecko-integration-branch: autoland gecko-reviewers: mats
jgraham
force-pushed
the
master
branch
6 times, most recently
from
d955567 to
c33d9e2
Compare
jgraham
pushed a commit
that referenced
this pull request
Aug 29, 2018
83cd4a064a chore(package): bump version number to 13.0.3 c4492f2f71 refactor(lib/writer): remove args() (web-platform-tests#184) b3b100f746 refactor: consume argument name in object spread way (web-platform-tests#183) 4aff72ec29 chore(package): bump version number to 13.0.2 d5f335a033 fix: allow required for an attribute name (web-platform-tests#182) 835e835461 chore(package): bump version number to 13.0.1 a209033036 refactor: unconsume by position (web-platform-tests#179) 494d31da45 chore(package-lock): run npm audit fix e2e83ac629 chore(package): bump version number to 13.0.0 8d04da9ed0 fix: consume return type for promise subtype (web-platform-tests#177) f116f14b97 add probe() function (web-platform-tests#176) eed64a06a3 BREAKING CHANGE: remove idlType.sequence (web-platform-tests#175) e6a76a1575 fix: prevent incorrect spaced negative infinity and variadic marks (web-platform-tests#173) 809e640d78 refactor: merge operation functions (web-platform-tests#172) cb558a3eff fix: allow selected keywords in argument name (web-platform-tests#171) bbb47c2174 fix: write inherit readonly attribute in proper order (web-platform-tests#170) 2babd47e1f refactor: merge attribute functions (web-platform-tests#166) 2ccd34fe18 chore(package): bump version number to 12.1.4 7cd23cdad5 fix: prevent readwrite attributes on namespaces (web-platform-tests#165) ddbc4a5682 chore(package): bump version number to 12.1.3 8628744060 fix: prevent incorrect union types (web-platform-tests#163) 60859b5253 chore(package): bump version number to 12.1.2 a73d090a31 fix(package.json): add file extension in the main field 2827821f2f chore(package): bump version number to 12.1.1 d639527ed1 fix: prevent tokeniser error when it meets _0 (web-platform-tests#161) 568675358b add files field to package.json (web-platform-tests#160) 68a37d21e8 chore(package): bump version number to 12.1.0 621d0b6c17 fix: prevent keywords from being identifiers (web-platform-tests#157) 9ad8932034 chore(package): bump version number to 12.0.0 a154b63cea BREAKING CHANGE: remove allowNestedTypedefs (web-platform-tests#155) 5a495f76a5 refactor: remove all_ws() and gather trivia implicitly (web-platform-tests#154) e717aa67fa tests: Remove test/widlproc (web-platform-tests#153) 131e74cc57 chore(package): bump version number to 11.0.0 09f8a1daae Prevent incorrect enums (web-platform-tests#151) fa060611a9 BREAKING CHANGE: remove opt.ws (web-platform-tests#150) 2bb4e1cbb2 chore(package): bump version number to 10.3.3 (web-platform-tests#149) 80936fa3c9 oefactor simple_extended_attr() (web-platform-tests#148) c060079cca docs: remove description about typePair (#147) 4169268630 docs: simple WebIDL checker. (#146) a28c7b55f7 chore(package): bump version number to 10.3.2 e311680dc0 fix: correctly handle whitespaces of implements and includes. (#145) 50c828344d refactor: remove eas.length check (#144) 968ca63fd4 refactor: one-to-one match for token matcher (#143) 8531535861 chore(package): bump version number to 10.3.1 96deeb3480 const-type as full IDL Type (#142) a13dfa8cf5 chore(package): bump version number to 10.3.0 c0ab164af2 always add extAttrs for .idlType (#141) 932dcfb96d docs(README): add missing typedef-type 56777f49dc docs(README): add missing types-of-types c14d7c1767 docs(README): add types of types (#140) 730a3b99db chore(CHANGELOG): regenerate git-subtree-dir: resources/webidl2 git-subtree-split: 83cd4a064a3a183268c4d6af0556a3f981f509c1
jgraham
force-pushed
the
master
branch
3 times, most recently
from
efa3035 to
e30043c
Compare
jgraham
force-pushed
the
master
branch
4 times, most recently
from
84a5e70 to
aac8664
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1435658
gecko-commit: c074e2c4b2ed6c733479cad11204244edb9e51ef
gecko-integration-branch: autoland
gecko-reviewers: mats