[Gecko Bug 1433145] Handle unexpected alerts when switching tests,#136
Open
jgraham wants to merge 42 commits into
Open
[Gecko Bug 1433145] Handle unexpected alerts when switching tests,#136jgraham wants to merge 42 commits into
jgraham wants to merge 42 commits into
Conversation
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1430622 gecko-commit: 2ea467872d7fcd3dbb31fcf881e4147b6dd6bebe gecko-integration-branch: autoland gecko-reviewers: xidorn, mats
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1303025 gecko-commit: 62f5c4a3682381134b607d359824b7605ec15156 gecko-integration-branch: autoland gecko-reviewers: bkelly
This is a partial revert of servo/servo@ce1d8cd If you're in a shadow tree, you may not be slotted but you still need to look at the slotted rules, since a <slot> could be a descendant of yours. Just use the same invalidation map everywhere, and remove complexity. This means that we can do some extra work while trying to gather invalidation if there are slotted rules, but I don't think it's a problem. The test is ported from https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/css/invalidation/slotted.html?l=1&rcl=58d68fdf783d7edde1c82a642e037464861f2787 Curiously, Blink fails the test as written, presumably because they don't flush styles from getComputedStyle correctly (in their test they do via updateStyleAndReturnAffectedElementCount), due to <slot>s not being in the flat tree in their implementation. bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1429846 gecko-commit: bec4537b2efd4f8381c5f398c71bc0f09d4da981 gecko-integration-branch: central gecko-reviewers: heycam
It makes no sense to pass a custom base size of zero in presence of rem, ex, or ch units. bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1431031 gecko-commit: a984a3218ffe8ebaad26bff890bc25f00612d859 gecko-integration-branch: central gecko-reviewers: Manishearth
… parser; bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1425079 gecko-commit: e862a06e4337d21d77adbd8eee3ddde485182ee2 gecko-integration-branch: central gecko-reviewers: smaug
This assertion is supposed to be used where the first argument has a tolerance but the second argument doesn't have such tolerance. Whereas assert_times_equal() is supposed to be used for the case both arguments have the same tolerance, actually it hasn't, it will be fixed in a subsequent patch in this patch series. bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1430654 gecko-commit: edbac2302f907df4fca6aea3843bd033a1a1bb89 gecko-integration-branch: central gecko-reviewers: birtles
Since the function assumes that both of actual and expected values have the same precision requirements. bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1430654 gecko-commit: a226a272784c3ac44a6b93136111fb78f2f312e5 gecko-integration-branch: central gecko-reviewers: birtles
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1430654 gecko-commit: 235797f7083a060ada86a217dc7c4e83d238f252 gecko-integration-branch: central gecko-reviewers: birtles
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1433145 gecko-commit: 8f5ee77b7511bf6fa6ca58f236101e8f692f1454 gecko-integration-branch: central gecko-reviewers: ato
jgraham
force-pushed
the
master
branch
6 times, most recently
from
d955567 to
c33d9e2
Compare
jgraham
force-pushed
the
master
branch
4 times, most recently
from
efa3035 to
e30043c
Compare
jgraham
force-pushed
the
master
branch
4 times, most recently
from
84a5e70 to
aac8664
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1433145
gecko-commit: 8f5ee77b7511bf6fa6ca58f236101e8f692f1454
gecko-integration-branch: central
gecko-reviewers: ato