[Gecko Bug 1422234] part 2: Add wpt-tests to check if insertParagraph command splits or doesn't split inline elements at their edge#135
Open
jgraham wants to merge 42 commits into
Open
Conversation
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1430622 gecko-commit: 2ea467872d7fcd3dbb31fcf881e4147b6dd6bebe gecko-integration-branch: autoland gecko-reviewers: xidorn, mats
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1303025 gecko-commit: 62f5c4a3682381134b607d359824b7605ec15156 gecko-integration-branch: autoland gecko-reviewers: bkelly
This is a partial revert of servo/servo@ce1d8cd If you're in a shadow tree, you may not be slotted but you still need to look at the slotted rules, since a <slot> could be a descendant of yours. Just use the same invalidation map everywhere, and remove complexity. This means that we can do some extra work while trying to gather invalidation if there are slotted rules, but I don't think it's a problem. The test is ported from https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/css/invalidation/slotted.html?l=1&rcl=58d68fdf783d7edde1c82a642e037464861f2787 Curiously, Blink fails the test as written, presumably because they don't flush styles from getComputedStyle correctly (in their test they do via updateStyleAndReturnAffectedElementCount), due to <slot>s not being in the flat tree in their implementation. bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1429846 gecko-commit: bec4537b2efd4f8381c5f398c71bc0f09d4da981 gecko-integration-branch: central gecko-reviewers: heycam
… parser; bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1425079 gecko-commit: e862a06e4337d21d77adbd8eee3ddde485182ee2 gecko-integration-branch: central gecko-reviewers: smaug
This assertion is supposed to be used where the first argument has a tolerance but the second argument doesn't have such tolerance. Whereas assert_times_equal() is supposed to be used for the case both arguments have the same tolerance, actually it hasn't, it will be fixed in a subsequent patch in this patch series. bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1430654 gecko-commit: edbac2302f907df4fca6aea3843bd033a1a1bb89 gecko-integration-branch: central gecko-reviewers: birtles
Since the function assumes that both of actual and expected values have the same precision requirements. bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1430654 gecko-commit: a226a272784c3ac44a6b93136111fb78f2f312e5 gecko-integration-branch: central gecko-reviewers: birtles
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1430654 gecko-commit: 235797f7083a060ada86a217dc7c4e83d238f252 gecko-integration-branch: central gecko-reviewers: birtles
…oesn't split inline elements at their edge Spec bug: w3c/editing#172 Inline elements in paragraph except anchor elements which have non-empty href attribute should be created in new paragraph even when new ones are empty because users must expect to keep writing some text with same style, but for anchor elements with non-empty href attribute, users must not expect to create same link in new paragraph in most cases. bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1422234 gecko-commit: 0637a8fc925bb17562559396f7217bb71e4b1c9e gecko-integration-branch: central gecko-reviewers: m_kato
jgraham
pushed a commit
that referenced
this pull request
Apr 27, 2018
dd57b9f0db chore(package): update dev deps 7f99dea07c chore(package): bump version number to 10.2.1 c357d4cb01 Add bug link and remove unnecessary quote tests cd1f7a95ba Add a comment about not using for (const ...) 39a957721c Tokenise a solitary '/' correctly 4efd252f5e Use "let" instead of "var" in for statement f940514f36 Add count() function. Use idiomatic string methods. affdfbdc2b Optimise tokenisation and whitespace skipping ba00d5d9ec refactor: small syntax changes (#137) d5c4fbfdfc chore(CHANGELOG): regenerate 3d009b634a chore(CHANGELOG): regenerate 23bb9bb290 chore(CHANGELOG): regenerate 6db306af62 chore(package): bump version number to 10.2.0 ac7ef088f3 fix: solve conflicts from typing union types f422f2a6f5 feat: type on union types (#135) bde0553b49 feat: add const-type for idlTypes (#132) c03cd7e8f3 feat: add dictionary/typedef-type (#133) 6eb1e7f4db feat: add argument/return type (#134) d2cfdfd901 feat: add type: attribute-type on idlTypes (#131) 1e29dcb71b Auto acquisition for parser result changes (#130) 154eabfbb1 chore(package): update mocha, expect, bump version 36932debd7 Let error messages include the current definition name (#129) 664f63b61e chore(package-lock): regenerate 536157bffa chore(package): bump version number to 10.0.0 d5b88179df chore(pacakge): upgrade expect dep 0c103b356e Maintain writer.js (#122) e2d4467ea1 remove typeExtAttrs from docs 0226b76587 remove iterator documentation (#123) e36ae6bf70 BREAKING CHANGE: remove deprecated iterator operation (#121) 8e73c4ff4c use for-of on tests c56a921d9b docs(README): iterables ildType is always array 3f39cb152e chore(CHANGELOG): regenerate ae0060f859 chore(package): bump version number to 9.0.0 24669ed245 BREAKING CHANGE: consistent array type for iterable.idlType (#117) f89b5803c7 Update package-lock.json f581ac63c3 Add myself to contributors in package.json 420ac52ac5 Revert "chore: drop Node 6 support (#102)" 1c031ed86e chore(CHANGELOG): regenerate git-subtree-dir: resources/webidl2 git-subtree-split: dd57b9f0db1adbb5712f9fdd6a4e38533ff4ba4b
jgraham
force-pushed
the
master
branch
5 times, most recently
from
d955567 to
c33d9e2
Compare
jgraham
force-pushed
the
master
branch
4 times, most recently
from
efa3035 to
e30043c
Compare
jgraham
force-pushed
the
master
branch
4 times, most recently
from
84a5e70 to
aac8664
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec bug: w3c/editing#172
Inline elements in paragraph except anchor elements which have non-empty
href attribute should be created in new paragraph even when new ones are
empty because users must expect to keep writing some text with same style,
but for anchor elements with non-empty href attribute, users must not
expect to create same link in new paragraph in most cases.
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1422234
gecko-commit: 0637a8fc925bb17562559396f7217bb71e4b1c9e
gecko-integration-branch: central
gecko-reviewers: m_kato