[Gecko Bug 1403923] Safely shutdown Firefox from in delete_session. r=jgraham#125
Open
jgraham wants to merge 16 commits into
Open
[Gecko Bug 1403923] Safely shutdown Firefox from in delete_session. r=jgraham#125jgraham wants to merge 16 commits into
jgraham wants to merge 16 commits into
Conversation
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1430622 gecko-commit: 2ea467872d7fcd3dbb31fcf881e4147b6dd6bebe gecko-integration-branch: autoland gecko-reviewers: xidorn, mats
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1303025 gecko-commit: 62f5c4a3682381134b607d359824b7605ec15156 gecko-integration-branch: autoland gecko-reviewers: bkelly
With the request to shutdown the browser, a given amount of time has to be waited to allow the process to shutdown itself. Only if the process is still running afterward it has to be killed. Firefox has an integrated background monitor which observes long running threads during shutdown, and kills those after 65s. To allow Firefox to shutdown on its own, geckodriver has to wait that time, and some additional seconds. bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1403923 gecko-commit: 025d4690bfbe602a82d91f827a67208df80dc110 gecko-integration-branch: central gecko-reviewers: jgraham
jgraham
force-pushed
the
master
branch
6 times, most recently
from
d955567 to
c33d9e2
Compare
jgraham
force-pushed
the
master
branch
4 times, most recently
from
efa3035 to
e30043c
Compare
jgraham
force-pushed
the
master
branch
4 times, most recently
from
84a5e70 to
aac8664
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the request to shutdown the browser, a given amount of time
has to be waited to allow the process to shutdown itself. Only
if the process is still running afterward it has to be killed.
Firefox has an integrated background monitor which observes
long running threads during shutdown, and kills those after
65s. To allow Firefox to shutdown on its own, geckodriver
has to wait that time, and some additional seconds.
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1403923
gecko-commit: 025d4690bfbe602a82d91f827a67208df80dc110
gecko-integration-branch: central
gecko-reviewers: jgraham