Skip to content

[Gecko Bug 1354211] Make WebDriver:ElementClear conforming to standard. r=automatedtester#110

Open
jgraham wants to merge 26 commits into
masterfrom
sync/upstream/open/1354211
Open

[Gecko Bug 1354211] Make WebDriver:ElementClear conforming to standard. r=automatedtester#110
jgraham wants to merge 26 commits into
masterfrom
sync/upstream/open/1354211

Conversation

@jgraham

@jgraham jgraham commented Jan 12, 2018

Copy link
Copy Markdown
Owner

This implements the remote end steps for the Element Clear command
from WebDriver in Marionette.

The WPT test webdriver/tests/interaction/element_clear.py was deleted
because it tested a previous definition of the Element Clear command
and many of its tests were either incorrect or replaced by the new tests.
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1354211
gecko-commit: f9f835bce31b7a0f40c2a8e69b83cf8aaf4b4024
gecko-integration-branch: autoland
gecko-reviewers: automatedtester

wpt-sync and others added 26 commits December 6, 2017 10:09
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=Bug 1383683
gecko-commit: e219b2b152d795da623814d7aeae3a89b1d2726e
gecko-integration-branch: central
gecko-reviewers: bz
…make overflow-clip-box a shorthand.

bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=Bug 1422839
gecko-commit: cf93ccd03ca7d452aa1e1e9bff575f0992df7874
gecko-integration-branch: autoland
gecko-reviewers: dholbert
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=Bug 1423412
gecko-commit: 7750a46652fa83acc6b8cd3e3bee8f428d24bfd5
gecko-integration-branch: central
gecko-reviewers: baku
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=Bug 1422319
gecko-commit: b10b128a4a23768315d1f951c777b29adbc242b4
gecko-integration-branch: central
gecko-reviewers: xidorn
Domain cookies retrieved from Marionette have leading dot characters in
them. This change will ensure that adding cookies with leading dot
characters works as expected.
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=Bug 1415828
gecko-commit: f5e24faf36fc0a27e5255ce2a22e0f50d1da2f36
gecko-integration-branch: central
gecko-reviewers: ato
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=Bug 1421675
gecko-commit: 4bdcd7f6e1978b4769629208fb479d93a859018a
gecko-integration-branch: central
gecko-reviewers: maja_zf
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=Bug 1037335
gecko-commit: 7678ac4b15adf33769ce558814fe44f84447ebe6
gecko-integration-branch: central
gecko-reviewers: ckerschb
…src/style-src-imported-style-blocked.html.

bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=Bug 1037335
gecko-commit: fd99633486a59a1771e84214998043e1a3684945
gecko-integration-branch: central
gecko-reviewers: ckerschb
This test is duplicated in
testing/web-platform/tests/webdriver/tests/interface.html.
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=Bug 1421676
gecko-commit: ad8f6896b87dfabdbbf0d6db28bdfaaf16158f6a
gecko-integration-branch: central
gecko-reviewers: maja_zf
…ransition tests more robust, and re-enable that test.

According to :birtles, it is not guaranteed that animationiteration
event will be fired. This event is sample-based rather than event-based,
and such behavior has been clarified in CSS Animations Level 2:
https://drafts.csswg.org/css-animations-2/#event-dispatch

Also, Chromium has the same issue with this test:
https://bugs.chromium.org/p/chromium/issues/detail?id=701445
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1351409
gecko-commit: fa855df2e888bb6edbed237d7a6b78ab6476c96b
gecko-integration-branch: central
gecko-reviewers: jmaher
…le map after fetch errors

bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1426140
gecko-commit: a8f97458d0cc43a62b048a5ebb4a8b1663d18b20
gecko-integration-branch: central
gecko-reviewers: baku
…ponse to a same origin request.

bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1427978
gecko-commit: e3edde0c2242804300ebd96b0a0f648ace682688
gecko-integration-branch: central
gecko-reviewers: bkelly
… run

bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1426675
gecko-commit: afef4f6c98755643a56ad15e39b3ac885877eb7d
gecko-integration-branch: central
gecko-reviewers: jgraham
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1426642
gecko-commit: f6b74e7c3c0943a212e0d2efd73340b8d2157dbb
gecko-integration-branch: central
gecko-reviewers: jgraham
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1419662
gecko-commit: 48bb9add84a85b085b2739d37798086fc6fd91d9
gecko-integration-branch: central
gecko-reviewers: smaug
…length.

At least when the animation-name length is bigger than the animation properties,
we mess up inheritance and only set properly the specified counts, then don't
cycle it.

The nicer fix for this is making these vectors properly, and move the cycling
logic at used-value time (bug 1420928). Same for transitions.
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1426246
gecko-commit: 064e0be1cc29617de74098aba4b3bb706775315a
gecko-integration-branch: central
gecko-reviewers: hiro
When WebDriver:ElementClick clicks an <option disabled> element,
its selectedness state should according to a new specification
change proposed not change:

	w3c/webdriver#1189

This patch provides tests for the specification change.
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1429384
gecko-commit: be8ebea8beb1e445a3382b6b071401f78de6e622
gecko-integration-branch: central
gecko-reviewers: automatedtester
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1361369
gecko-commit: db30c73b1542d381d4240f43d76225478105f894
gecko-integration-branch: central
gecko-reviewers: smaug
…nd about:srcdoc cases.

bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1426979
gecko-commit: a4c611046a0c977a82d0797af446a1b2fca2ee7a
gecko-integration-branch: central
gecko-reviewers: asuth
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1403986
gecko-commit: 47098bf648b46df0c3de105884421684dc4ace32
gecko-integration-branch: central
With the request to shutdown the browser, a given amount of time
has to be waited to allow the process to shutdown itself. Only
if the process is still running afterward it has to be killed.

Firefox has an integrated background monitor which observes
long running threads during shutdown, and kills those after
65s. To allow Firefox to shutdown on its own, geckodriver
has to wait that time, and some additional seconds.
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1403923
gecko-commit: 025d4690bfbe602a82d91f827a67208df80dc110
gecko-integration-branch: central
gecko-reviewers: jgraham
The upstream upgrade of pytest came with a new test progress
percentage feature that introduced a lot of unnecessary log output
in WPT wdspec tests.

This adds a pytest flag that reverts it to use the "classic" output
style, which does not have a test progress bar.
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1429388
gecko-commit: 4f065bc82a465371aaa8b6dc0de9514cf6e859c8
gecko-integration-branch: central
gecko-reviewers: davehunt, jgraham
The fact that the queues were not drained on exist seemed to cause an
intermittent failure where one process tried to write to a queue that
another had closed. Draining the queues explicitly should avoid this
and ensure we surface hidden problems in the log.
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1400716
gecko-commit: 0ea252bf357c2ff56b9f0dcd6db6d094efc7a1e8
gecko-integration-branch: central
gecko-reviewers: maja_zf
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1400716
gecko-commit: 38a8726fbde26796847294962cc9edd369091fee
gecko-integration-branch: central
gecko-reviewers: maja_zf
…ssion`.

By calling "delete_session" the currently used session id always has to be reset,
because each session has its own unique id.
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1429562
gecko-commit: ec1a634f8feaa198469acf34f37d13e917175226
gecko-integration-branch: autoland
gecko-reviewers: ato
This implements the remote end steps for the Element Clear command
from WebDriver in Marionette.

The WPT test webdriver/tests/interaction/element_clear.py was deleted
because it tested a previous definition of the Element Clear command
and many of its tests were either incorrect or replaced by the new tests.
bugzilla-url: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1354211
gecko-commit: f9f835bce31b7a0f40c2a8e69b83cf8aaf4b4024
gecko-integration-branch: autoland
gecko-reviewers: automatedtester
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants