Design#46
Conversation
There was a problem hiding this comment.
Run it through your own formatter.
--- Original Message ---
From: "James Lamine" notifications@github.com
Sent: May 8, 2015 5:40 PM
To: "jglamine/calvinwebprint" calvinwebprint@noreply.github.com
Cc: "FreedCapybara" templeandrew@hotmail.com
Subject: Re: [calvinwebprint] Design (#46)
@@ -4,69 +4,64 @@
<script type="text/x-handlebars" data-template-name="application"> {{#if isAuthenticated}} - {{partial "welcome"}} - {{partial "welcome"}}
This need to be less indented
Reply to this email directly or view it on GitHub:
https://github.com/jglamine/calvinwebprint/pull/46/files#r29979224
|
Great, I'll take a look and let you know when I'm done with code review. |
There was a problem hiding this comment.
These two lines should be less indented.
|
Ok, I gave it a quick one-over. See my comments, mostly about formatting things. We should re-render the logo so that the lines are pixel-fitted. See this blog post by Dustin Kurtis for details: http://dcurt.is/pixel-fitting Please squash your changes into one commit. You can use an interactive rebase |
2 participants
Design updates from last week