Skip to content

Issue #15514 - Avoid duplicate lifecycle failure logging #15521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DragonFSKY wants to merge 1 commit into
base: jetty-12.1.x
Choose a base branch
from
+9 −23
Open

Issue #15514 - Avoid duplicate lifecycle failure logging #15521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/component/AbstractLifeCycle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,8 +294,6 @@ private void setStopped()
private void setFailed(Throwable th)
{
_state = State.FAILED;
if (LOG.isDebugEnabled())
LOG.warn("FAILED {}: {}", this, th, th);
for (EventListener listener : _eventListeners)
{
if (listener instanceof Listener)
Expand Down
30 changes: 9 additions & 21 deletions ...core/jetty-util/src/test/java/org/eclipse/jetty/util/component/LifeCycleListenerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@

package org.eclipse.jetty.util.component;

import org.eclipse.jetty.logging.StacklessLogging;
import org.eclipse.jetty.util.NanoTime;
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertSame;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;

Expand All @@ -35,16 +35,10 @@ public void testStart() throws Exception

lifecycle.setCause(cause);

try (StacklessLogging stackless = new StacklessLogging(AbstractLifeCycle.class))
{
lifecycle.start();
assertTrue(false);
}
catch (Exception e)
{
assertEquals(cause, e);
assertEquals(cause, listener.getCause());
}
Exception failure = assertThrows(Exception.class, lifecycle::start);
assertSame(cause, failure);
assertTrue(lifecycle.isFailed());
assertSame(cause, listener.getCause());
lifecycle.setCause(null);

lifecycle.start();
Expand Down Expand Up @@ -76,16 +70,10 @@ public void testStop() throws Exception
lifecycle.start();
lifecycle.setCause(cause);

try (StacklessLogging stackless = new StacklessLogging(AbstractLifeCycle.class))
{
lifecycle.stop();
assertTrue(false);
}
catch (Exception e)
{
assertEquals(cause, e);
assertEquals(cause, listener.getCause());
}
Exception failure = assertThrows(Exception.class, lifecycle::stop);
assertSame(cause, failure);
assertTrue(lifecycle.isFailed());
assertSame(cause, listener.getCause());

lifecycle.setCause(null);

Expand Down