Create DataFrame key columns for propagation and simplify key handling - #20
Merged
jeromychu23 merged 3 commits intoMar 16, 2026
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef443181fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
value_to_key/composite_key) and rely onpolarsexpressions to produce stable string keys.propagate_target_rowsAPI to operate on named key columns rather than slices of column names.Description
value_to_keyandcomposite_keyand addkey_from_rowthat reads a precomputed string key from a row by column name.propagate_target_from_ancestorbuild temporary key columns__self_keyand__parent_keyusing a localbuild_key_exprwhich usespolars.col(...).cast(String).fill_null("<null>")andpolars.concat_str(separator="##"), then callwith_columnsto attach them to the DataFrame.propagate_target_rowssignature to acceptself_key_colandparent_key_coland update its internal lookups to usekey_from_row.__self_key/__parent_keyvia a helperrows_with_keys.Testing
cargo testwhich executed the propagation tests.blocker_terminates_chain_resolution,node_level_self_blocker_prevents_propagation,node_level_self_blocker_not_later_does_not_block,node_level_parent_blocker_prevents_propagation, andblocker_checks_use_start_target_as_anchor_across_ancestorswere executed and passed.Codex Task