Work-from-home - #19
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e185619337
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let target_before_block = match &earliest_blocker { | ||
| None => true, | ||
| Some(blocker_target) => { | ||
| compare_bool(&candidate_target, blocker_target.bind(py), CompareOp::Lt) | ||
| } |
There was a problem hiding this comment.
target_before_block only checks whether candidate_target is less than the blocker target. In backward mode, choose_candidate_by_plan already constrains candidates to <= anchor_target, while blockers are filtered to > anchor_target in earliest_blocker_on_node_after_target, so this condition becomes trivially true and block_key no longer blocks anything. As a result, rows that should stay unchanged when a later blocker exists can incorrectly inherit ancestor targets.
Useful? React with 👍 / 👎.
1 participant
No description provided.