Handle edge case causing out-of-bound reads#464
Open
MichaelChirico wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes all three of the following upstream bugs:
That repo is essentially unmaintained, so I didn't file these patches there.
Bug fixed by Gemini, as were the test cases with some amount of touch-up by me for style (but which are basically copied from the bug reports). I also had Gemini confirm the error is present in {jsonlite} absent the patch with
valgrind.Applied internally, this patch passes all downstreams of yajl, including a subset of jsonlite downstreams and some other C/C++ codebases.