Insert buffer-file-name as FILE if pdf-view-mode is active - #5
Open
fapdash wants to merge 1 commit into
Open
Conversation
fapdash
force-pushed
the
insert-current-file-name
branch
from
July 26, 2021 08:42
6eb4db2 to
aaddfee
Compare
fapdash
changed the title
Owner
|
I like the idea so go ahead and make it cleaner. Also, we support both |
fapdash
force-pushed
the
insert-current-file-name
branch
from
July 29, 2021 16:35
aaddfee to
bae4737
Compare
- checks if pdf-view-mode is active - checks if doc-view-mode is active - if either one is active it inserts the file name of the currently loaded document as FILE - adds tests - adds test command to README
fapdash
force-pushed
the
insert-current-file-name
branch
from
July 29, 2021 16:40
bae4737 to
13ab125
Compare
Author
|
@jeremy-compostella Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jeremy-compostella I know the code could be cleaner but I wanted to first check if you are generally interested in this change?