Silence byte-compiler warnings - #4
Open
leungbk wants to merge 2 commits into
Open
Conversation
jeremy-compostella
left a comment
jeremy-compostella
left a comment
Owner
There was a problem hiding this comment.
Here is the result of byte-compile on the current version of pdfgrep with Emacs 27.1.
~/.emacs.d/elpa/pdf-tools-20200214.536/pdf-outline.elc:Warning: ‘title’ is an
obsolete variable (as of 25.1); use 'title instead
Leaving directory ‘/home/jcompost/Documents/GordonPeak/’
Compiling file /home/jcompost/MyPersonalWork/j2m-emacs-config/pdfgrep/pdfgrep.el at Wed Feb 3 10:05:46 2021
Entering directory ‘/home/jcompost/MyPersonalWork/j2m-emacs-config/pdfgrep/’
which warning is this patch addressing ?
jeremy-compostella
approved these changes
Feb 3, 2021
Owner
|
The second commit looks good to me. |
Owner
|
Here is the result of which warning is this patch addressing ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also autoload
pdfgrep-mode.