Purge LinkedLogRotator by orgads · Pull Request #47 · jenkinsci/matrix-project-plugin

orgads · 2017-05-01T07:34:07Z

It is O(n^2), and looks like it adds no real value. The normal rotator should delete all the builds.

This might be the cause for JENKINS-38334

olivergondza · 2017-05-02T08:22:07Z

I am trying to understand what an impact fo such a change would be.

The LinkedLogRotator does not ever seem to get serialized (grepped my backups). Good.
Presumably it was introduced before MatrixBuild#delete was refactored to delete its configuration builds so it might be unnecessary these days. Good.
BUT, the LinkedLogRotator is deleting inactive configurations - is this taken care of as well?

It is O(n^2), and looks like it adds no real value. The normal rotator should delete all the builds.

orgads force-pushed the no-rotator branch from c1b213b to 5bbeb07 Compare October 31, 2017 13:22

Purge LinkedLogRotator

d1a2eec

It is O(n^2), and looks like it adds no real value. The normal rotator should delete all the builds.

orgads force-pushed the no-rotator branch from 5bbeb07 to d1a2eec Compare November 19, 2018 07:21

Provide feedback