Align GenericWhitespace ws.illegalFollow message with Checkstyle default#27120
Merged
MarkEWaite merged 1 commit intoJul 21, 2026
Conversation
MarkEWaite
approved these changes
Jul 20, 2026
MarkEWaite
left a comment
Contributor
There was a problem hiding this comment.
Confirmed that the new message matches the checkstyle source code.
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process.
/label ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
GenericWhitespacemodule insrc/checkstyle/checkstyle-configuration.xmloverrides fourmessages as
"GenericWhitespace "+ Checkstyle's default text. Three match the default;ws.illegalFollowreads"should followed by whitespace"— ungrammatical, and not what the checkreports. It was written that way in #6149, where Checkstyle 9.2.1 already defaulted to
''{0}'' is followed by an illegal character.This aligns the override with that default,restoring the pattern the other three follow.
Testing done
No automated test: a message-string override has no test surface. Verified
ws.illegalFollow=''{0}'' is followed by an illegal character.inchecks/whitespace/messages.propertiesof checkstyle 13.8.0, the version pinned inpom.xml.mvn checkstyle:check -pl cliwith the change: BUILD SUCCESS, 0 violations — the ruleset stillparses and flags the same code.
Screenshots (UI changes only)
Before
After
Proposed changelog entries
Proposed changelog category
/label skip-changelog
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.