Show a 'Success' banner on Manage Jenkins page save#27097
Open
janfaracik wants to merge 9 commits into
Open
Conversation
janfaracik
marked this pull request as ready for review
July 16, 2026 07:07
Contributor
|
Now the save button does the same as the apply button? Then we can remove one of them |
Member
Author
I agree. Thoughts on me doing it is as part of this PR or a follow up? |
Member
makes sense to do this but only in the new version |
Member
|
Could you update the screenshot in the description? |
Member
Author
Happy with this @mawinter69 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the new Manage Jenkins world, it doesn't make sense to redirect users after saving a page (and it could be argued it never did). This PR fixes that, keeping users on the same page when they hit save and displays a nice little notification to indicate that the save was successful. Based on PR comments, also removed the 'Apply' button for experimental pages as with this new experience it doesn't make sense.
Precursor to making the new Manage Jenkins UX the default.
Testing done
Screenshots (UI changes only)
Proposed changelog entries
Proposed changelog category
/label web-ui,rfe
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.