Skip to content

Show a 'Success' banner on Manage Jenkins page save#27097

Open
janfaracik wants to merge 9 commits into
jenkinsci:masterfrom
janfaracik:manage-jenkins-redirect
Open

Show a 'Success' banner on Manage Jenkins page save#27097
janfaracik wants to merge 9 commits into
jenkinsci:masterfrom
janfaracik:manage-jenkins-redirect

Conversation

@janfaracik

@janfaracik janfaracik commented Jul 15, 2026

Copy link
Copy Markdown
Member

In the new Manage Jenkins world, it doesn't make sense to redirect users after saving a page (and it could be argued it never did). This PR fixes that, keeping users on the same page when they hit save and displays a nice little notification to indicate that the save was successful. Based on PR comments, also removed the 'Apply' button for experimental pages as with this new experience it doesn't make sense.

Precursor to making the new Manage Jenkins UX the default.

Testing done

  • Clicking Save on a Manage Jenkins page stays on the page
  • A 'Success' banner appears

Screenshots (UI changes only)

martini

Proposed changelog entries

  • Show a 'Success' banner on Manage Jenkins page save

Proposed changelog category

/label web-ui,rfe

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@comment-ops-bot comment-ops-bot Bot added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jul 16, 2026
@janfaracik janfaracik changed the title Show a notification on Manage Jenkins page save Show a 'Success' banner on Manage Jenkins page save Jul 16, 2026
@janfaracik
janfaracik marked this pull request as ready for review July 16, 2026 07:07
@janfaracik
janfaracik requested a review from a team July 16, 2026 07:15
@mawinter69

Copy link
Copy Markdown
Contributor

Now the save button does the same as the apply button? Then we can remove one of them

@janfaracik

Copy link
Copy Markdown
Member Author

Now the save button does the same as the apply button? Then we can remove one of them

I agree. Thoughts on me doing it is as part of this PR or a follow up?

@timja

timja commented Jul 16, 2026

Copy link
Copy Markdown
Member

Now the save button does the same as the apply button? Then we can remove one of them

I agree. Thoughts on me doing it is as part of this PR or a follow up?

makes sense to do this but only in the new version

@MarkEWaite MarkEWaite changed the title Show a 'Success' banner on Manage Jenkins page save Show a 'Success' banner on new Manage Jenkins page save Jul 16, 2026
@MarkEWaite MarkEWaite changed the title Show a 'Success' banner on new Manage Jenkins page save Show a 'Success' banner on Manage Jenkins page save Jul 16, 2026

@timja timja left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timja

timja commented Jul 18, 2026

Copy link
Copy Markdown
Member

Could you update the screenshot in the description?

@janfaracik
janfaracik requested review from a team and mawinter69 July 18, 2026 19:36
@janfaracik

Copy link
Copy Markdown
Member Author

Now the save button does the same as the apply button? Then we can remove one of them

Happy with this @mawinter69 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants