Introduce .mvn: generic migration to incrementals (transplant from ircbot-plugin)#27
Open
jimklimov wants to merge 4 commits into
Open
Introduce .mvn: generic migration to incrementals (transplant from ircbot-plugin)#27jimklimov wants to merge 4 commits into
jimklimov wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @Flowdalic : as a sibling to PR #26, this one tries to introduce the bits needed for Maven builds of the project, its dependency tracking and so on. Generic rituals were applied, but e.g. the dependency names/locations/versions need to be spelled out so I hope you can edit this PR branch and rectify that :)
Eventually, after
mvn packageworks well, you can modify the Jenkinsfile to use this mechanism: https://github.com/jenkinsci/ircbot-plugin/blob/master/JenkinsfileNormally you would call just
buildPlugin()but recently the (docker) systems it is using by default were unstable, so calling explicitly container ones as spelled in that current file may be better. If defaults change by the time you get to this, so be it :)