Filtering Events Feature Request#353
Open
dawitgirm wants to merge 15 commits into
Open
Conversation
sarah-witt
reviewed
Jul 31, 2023
…ties.java Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
…lConfiguration.java Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
…lConfigurationTest.java Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
…lConfiguration.java Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
…e string rather than event
… for env variable conflicts
6 tasks
Collaborator
|
@sarah-witt should we close this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Currently, the filtering of events was limited to a toggle which turned on/off categories of events with no granular control of specific events to be sent.
Link to Issue
Description of the Change
Filtering is done by adding names for all the events and having users manually write include/exclude lists of specific events that they do/don't want. The higher level control of the toggles are still available but more specific include/excludes can be done with these lists. The config changed event was also removed completely as this event was blocked by the events team.
Alternate Designs & Possible Drawbacks
Link to RFC discussing this
Verification Process
Link to testing plan for unit and manual testing
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.