Set IncludeGraphicalSubtitles default to false - #64
Open
alvitali wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with server v10.11, graphical subtitle extraction in the plugin is enabled by default. This leads to the server's
/config/data/subtitlesdirectory ballooning in size, with graphic subtitles taking up a multiple of space.On a sample library of 150 movie files, the extracted subtitle directory takes up
51MB with text-based subtitles only
8.6GB with extraction of image-based subtitles enabled, a 168x increase in size (!)
Graphical subtitles don't benefit from extraction to the same extent as text-based subtitles do as they're burned in on the server side. Without the bottleneck of time-consuming on-the-fly extraction server-side, the biggest upside of extracting subtitles is nullified afaik - so I think defaulting
IncludeGraphicalSubtitlesto false is a much more sane approach for most server admins (with the option to enable it for advanced use cases) imo.This should resolve the underlying root cause of issues like #54 and #55 (users running out of disk space after updating to 10.11) without server admins having to troubleshoot what's responsible for a server's large config directory.
Thank you @Gorgorot38 for the amazing improvements in #53!