Initially tried working with the MessageKit framework but I couldn't …#2
Open
tcote19 wants to merge 1 commit into
Open
Initially tried working with the MessageKit framework but I couldn't …#2tcote19 wants to merge 1 commit into
tcote19 wants to merge 1 commit into
Conversation
…quite understand it. Borrowed some code from Kavsoft for adding a dynamically resizing message view.
jeksys
reviewed
Apr 12, 2021
jeksys
left a comment
jeksys
left a comment
Owner
There was a problem hiding this comment.
Do you think it makes sense to finish chat view and link it a data source before merging to master?
| UIResponder.keyboardDidShowNotification, object: nil, queue: .main) { | ||
| (data) in | ||
|
|
||
| let height1 = data.userInfo![UIResponder.keyboardFrameEndUserInfoKey] |
Owner
There was a problem hiding this comment.
[critical] forced unwrapping is not good, can cause a crash
| } | ||
|
|
||
|
|
||
| struct chatInstance : View { |
Owner
There was a problem hiding this comment.
[nitpick] let's follow Swift standards and name structs with the capital letter
| package = 0DEE520725D0BA71003C6EB7 /* XCRemoteSwiftPackageReference "swift-protobuf" */; | ||
| productName = SwiftProtobuf; | ||
| }; | ||
| 8A713CCF2623EAD300F6D4BB /* MessageKit */ = { |
Owner
There was a problem hiding this comment.
If MessageKit is not used can you please remove it
Collaborator
Author
There was a problem hiding this comment.
What's the proper way to do this?
Collaborator
Author
|
Yeah, can do. I definitely need to get a better understanding on how the messages interface with the devices. |
zls1988
pushed a commit
to zls1988/Meshtastic-iOS
that referenced
this pull request
Aug 1, 2021
zls1988
pushed a commit
to zls1988/Meshtastic-iOS
that referenced
this pull request
Aug 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially tried working with the MessageKit framework but I couldn't quite understand it. Borrowed some code from Kavsoft for adding a dynamically resizing message view.