Add support for bottom screws#15
Open
hrw wants to merge 1 commit into
Open
Conversation
When there is a `screw_bottom = True` in parameters file then supports are added to the top plate. There are still holes left in top plate... Partialy fixes: jeffminton#13
Owner
|
Can you post the scad and stl files created with this change? |
Author
|
Input files: Output files: (github disallows SCAD/STL files) |
Author
|
It is still far from being perfect but looks good enough for me for my next print. |
Owner
|
Thanks. Let me do some quick testing and I will pull this in. Adding code to close off the top holes when using bottom screws might take some time. One reason I didn't do it at first it I often use a tap to cut threads in my prints and without an open hole all the way through the bottom of the hole fills with the cut plastic. I probably wouldn't make it a default but another option |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is a
screw_bottom = Truein parameters file then supports are added to the top plate instead of bottom one.There are still holes left in top plate...
Partialy fixes: #13