Skip to content

no additional ipv4/6 configuration when disabled - #24

Open
kbucheli wants to merge 2 commits into
jednoprsak:mainfrom
kbucheli:minimal_disabled_config
Open

no additional ipv4/6 configuration when disabled#24
kbucheli wants to merge 2 commits into
jednoprsak:mainfrom
kbucheli:minimal_disabled_config

Conversation

@kbucheli

Copy link
Copy Markdown
Contributor

This PR refactors the ipv4 and ipv6 configuration hash generation into a own function each.

In these functions additional configuration is only attached if the respective family is enabled.

On my test node (using only connection resources :-( ) I get now no additional configuration except that IPv4 and IPv6 are disabled.

[root@lxdev08 ~]# cat /etc/NetworkManager/system-connections/sniffer.nmconnection 
# THIS FILE IS CONTROLLED BY PUPPET

[connection]
interface-name=ens224
id=sniffer
uuid=ddc5b71b-d603-5c1e-a8c7-03b11d9b00c1
type=ethernet

[ipv4]
method=disabled

[ipv6]
method=disabled
[root@lxdev08 ~]# 

@kbucheli

Copy link
Copy Markdown
Contributor Author

Do you find a minute or two to look at this pull request?

@jednoprsak

Copy link
Copy Markdown
Owner

Thank you for your reminder. We will look at it when we have time.

@kbucheli
kbucheli force-pushed the minimal_disabled_config branch from a18b4d6 to b5377e4 Compare January 27, 2025 15:42
@samuraiii

Copy link
Copy Markdown
Collaborator

I will test this and merge it if ti is OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants