0.11.0#18
Merged
Merged
Conversation
This feature set adds automatic document setup for optimal resource loading for fonts, css, and js. It also extends the document module by adding a streaming method to return head first to the browser document_streamer is added as welll which combines the two features.
I had trouble reading the docs from our docs page, so I decided this needed a full pass. The quick start was polished, and we added some stuff like document_generator.
First pass Parameter hints weren't displaying at all which is the opposite of what we want. We're going to try a 'value hint' prefix for the untyped elements.
* track completion status * on exceptions, terminate task runner * detect if the daemon has died * send sigkill if exiting is hung and user hits Ctrl C * fix pylance docstring parser bug in watchcond by swapping args
This is probably the best extension-forward way to handle this transition
pyright/basedpyright informed. Lots of casts were used and I'm not sorrry. * module exports elements/etc correctly per pyright * __class_getitem__ -> metaclass impl of h1['text'] / constructor skip. informed by type hinters believing the former returned type[h1] instead of instance of h1. * For metaclass, the _HasHtml protocol inheritence was dropped. protocols are runtime detected without interfaces anyway and we implement __html__.
This means you can p[ 'text', br, 'new line text' }
src/html_compose/base_element.py:186: error: Incompatible types in assignment (expression has type "str | float | int | bool | Iterable[str | float | int | bool] | Mapping[str | float | int | bool, bool] | None", variable has type "str") [assignment] src/html_compose/base_element.py:201: error: Incompatible types in assignment (expression has type "str | float | int | bool | Iterable[str | float | int | bool] | Mapping[str | float | int | bool, bool] | None", variable has type "str") [assignment]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.11.0
js_import, css_import, and font_import helpers
head element before other content.
which wrap other functionality in the module.
The signature is now different which may require updates.
Output single elements when we identify an attribute could be a list
Pyright on Zed seems to tolerate this better.
reload until after the server responds
p['line 1', br, 'line 2']where previously you had tobr()