fix: Enter in filtering mode now confirms selection in MultiSelect#165
Conversation
Greptile SummaryThis PR fixes filtering mode in
Confidence Score: 5/5The change is safe to merge; it correctly unifies two code paths around a shared helper and the guard that previously silenced Enter in filtering mode has been removed. The extraction of No files require special attention. Important Files Changed
Reviews (4): Last reviewed commit: "fix: Enter in filtering mode now confirm..." | Re-trigger Greptile |
There was a problem hiding this comment.
Code Review
This pull request refactors the MultiSelect component by extracting selection validation into a new try_confirm method, reducing duplication in the Key::Enter handling for both filtering and non-filtering states. The reviewer suggests further deduplication by moving terminal cleanup and rendering logic into a dedicated confirm helper method. Additionally, an unnecessary guard in the filtering branch was identified that could prevent users from confirming valid selections when no options match the current filter.
ae324bd to
cfe0003
Compare
cfe0003 to
16908b4
Compare
No description provided.