fix: allow ArrowUp/ArrowDown/Space during filtering in multiselect#164
Conversation
There was a problem hiding this comment.
Code Review
This pull request enables navigation and item toggling within the filtering mode of the MultiSelect component. Feedback highlights a potential panic risk due to unclamped cursor indices when the filtered list size changes, and a UX conflict where using the Space key for toggling prevents multi-word search queries. It is recommended to use the Tab key for toggling and to ensure the cursor is properly clamped.
Greptile SummaryThis PR enables ArrowUp, ArrowDown, and the toggle key (defaulting to Space) during filtering in
Confidence Score: 5/5Safe to merge — all previously flagged defects are addressed and no new issues were found. The stale-cursor bug, the out-of-bounds access in handle_toggle, and the missing help-text updates are all resolved in this diff. The toggle_key guard arm is correctly ordered ahead of the Char wildcard so Space interception works as designed. No regressions were found in the existing rendering or paging logic. No files require special attention. Important Files Changed
Reviews (5): Last reviewed commit: "fix(multiselect): support filtering navi..." | Re-trigger Greptile |
…ey, and cursor clamping
pitchfork relies on this fix!