Skip to content

Add GitHub Actions workflow#32

Open
marvinschopf wants to merge 1 commit into
jdah:masterfrom
marvinschopf:master
Open

Add GitHub Actions workflow#32
marvinschopf wants to merge 1 commit into
jdah:masterfrom
marvinschopf:master

Conversation

@marvinschopf

Copy link
Copy Markdown

Hello @jdah!

I have added a small GitHub Actions CI workflow.

Kind regards
Marvin

@mathisve

Copy link
Copy Markdown

Looks good to me!

@Daniellop1 Daniellop1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Tiebe

Tiebe commented Apr 19, 2021

Copy link
Copy Markdown

Shouldn't you run make libs as well?

@mathisve

Copy link
Copy Markdown

That shouldn't be an issue @Tiebe.
When running the workflow in nektos act, it automatically does make libs.
The only thing I had to change was add sudo apt-get update && sudo apt-get install make cmake clang.
But I'm guessing that's just a side-effect of nektos act itself.

@Tiebe

Tiebe commented Apr 20, 2021

Copy link
Copy Markdown

Ah alright!

@DamieFC DamieFC left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good!

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@xAffan xAffan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is good⚠️

@MarcelCoding

Copy link
Copy Markdown

How about uploading the binary as an artifact? https://github.com/actions/upload-artifact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants