refactor: deduplicate helpers and extract report suppression#23
Merged
Conversation
Owner
jcouture
commented
Apr 30, 2026
jcouture
commented
- replace O(n) observationForFinding scan with map-based index lookup
- consolidate duplicate lineDistance into finding.LineDistance
- rename isTokenRune to isIdentRune for clarity
- extract finding suppression logic from human.go into suppress.go
- add doc comments to all exported engine types and methods
- simplify isWhitespaceLikeRegion to avoid slice allocation
- remove redundant ErrBinaryContent special-case in run.go
- add missing rule categories to JSON report output
…ppression - replace O(n) observationForFinding scan with map-based index lookup - consolidate duplicate lineDistance into finding.LineDistance - rename isTokenRune to isIdentRune for clarity - extract finding suppression logic from human.go into suppress.go - add doc comments to all exported engine types and methods - simplify isWhitespaceLikeRegion to avoid slice allocation - remove redundant ErrBinaryContent special-case in run.go - add missing rule categories to JSON report output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.