Skip to content

Adjust request rate limiting #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcarpe merged 2 commits into from
Jun 7, 2025
Merged

Adjust request rate limiting #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f4794a
fix broken xml in full gams list
jcarpe Jun 7, 2025
d9b0d41
fix rate limit sleep timer
jcarpe Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion full-games-clz-list.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64313,4 +64313,5 @@
<shoulduploadfrontcover boolvalue="True">Yes</shoulduploadfrontcover>
<shoulduploadbackcover boolvalue="True">Yes</shoulduploadbackcover>
</game>
</gamelist>
</gamelist>
</gameinfo>
6 changes: 4 additions & 2 deletions src/adapters/igdb/igdb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ func fuzzyFindIGDBGameByTitle(title string, clzPlatformName string) int {
// Search for the game by normalized title
gamesData := fuzzySearchByTerm(normalizedTitle)
if len(gamesData) == 0 {
fmt.Printf("No games found in FuzzyFind for title: %s\n", title)
fmt.Printf("FuzzyFind failed for title: %s\n", normalizedTitle)
return 0
}

Expand Down Expand Up @@ -146,10 +146,12 @@ func fuzzyFindGamesList(gameList []domain.Game) []domain.Game {
fmt.Printf("Invalid IGDB_API_RATE_LIMIT value: %v -- setting to 0\n", err)
rateLimit = 0 // Default to 0 second if parsing fails
}
sleepTime := time.Duration(rateLimit)

sleepTime := time.Duration(rateLimit) * time.Millisecond

for i, game := range gameList {
if i != 0 {
fmt.Printf("%d Sleeping for rate limit...\n", i)
// Sleep for a short duration to avoid hitting the rate limit
time.Sleep(sleepTime)
}
Expand Down
4 changes: 2 additions & 2 deletions src/domain/clz-translation/translate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,9 +221,9 @@ func TranslateCLZ(input string, igdbSupplement bool) domain.GameCollection {
rateLimit, err := strconv.Atoi(rateLimitStr)
if err != nil {
fmt.Printf("Invalid IGDB_API_RATE_LIMIT value: %v\n", err)
rateLimit = 2000 // Default to 2000 second if parsing fails
rateLimit = 500 // default to 500 milliseconds if parsing fails
}
sleepTime := time.Duration(rateLimit)
sleepTime := time.Duration(rateLimit) * time.Millisecond

for _, batchQuery := range batchQueries {
// retrieve IGDB data for each batch
Expand Down