fix(renovate): detect vendored deps under devices/vendor/#44
Merged
Conversation
`config:recommended` pulls in the `:ignoreModulesAndTests` preset, whose ignorePaths includes `**/vendor/**` and `**/examples/**`. Our vendored TubesZB Z-Wave and MGM24 configs live under `devices/vendor/`, so Renovate skipped them before any manager ran — the `# renovate: datasource=git-refs` annotations for tube0013/TubesZB-ESPHome-Builder and tube0013/esphome-components were never detected (they were absent from the dependency dashboard, while the top-level devices/*.yaml annotations were picked up). Override ignorePaths to just the npm-style trees this repo will never contain (.esphome/ build caches are already gitignored). Verified with `renovate --platform=local --dry-run=extract`: both vendor configs' deps now extract. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Renovate dependency dashboard (#14) was not detecting the vendored dependencies in
devices/vendor/:tube0013/TubesZB-ESPHome-Builder(intubeszb-zw.yamlandtubeszb-mgm24.yaml)tube0013/esphome-components(intubeszb-mgm24.yaml)The
# renovate: datasource=git-refs …annotations and the custom managers were all correct — the three annotations in top-leveldevices/*.yaml(bluetooth-proxy, garage-door, hot-tub) were being detected fine.Root cause
config:recommendedextends the:ignoreModulesAndTestspreset, whose defaultignorePathsincludes**/vendor/**and**/examples/**. Renovate appliesignorePathsbefore any manager runs, so every file underdevices/vendor/was skipped regardless of ourmanagerFilePatterns. Ourdevices/vendor/holds first-class vendored ESPHome configs, not throwaway third-party trees, so the default exclusion is wrong for this repo.Fix
Override
ignorePathsto just the npm-style trees this repo will never contain (node_modules,bower_components), droppingvendor/examples/tests..esphome/build caches are already gitignored so Renovate never sees them.Verification
renovate-config-validatorpasses.renovate --platform=local --dry-run=extractnow extractstube0013/TubesZB-ESPHome-Builderandtube0013/esphome-componentsfrom bothdevices/vendor/*.yamlfiles (previously absent).After this merges, the dependency dashboard's regex section should grow from 3 to 5 entries (the two vendor files).
🤖 Generated with Claude Code