Feat/safety quarantine#16
Merged
Merged
Conversation
The per-feed staleness checks catch a single bad feed; this is the backstop for a collective mispricing that passes every per-feed check (a compromised constituent token, a correlated oracle failure). - Guardian role and pause state: the guardian or owner can pause, the owner unpauses after review. whenNotPaused gates the value-moving entry points (settle, both request lanes, sync deposit and redeem) and isValidSignature, while already-settled claims stay open since their value was fixed at a prior validated settlement. Pause stops execution, not clocks. - NAV-per-share circuit breaker at settle: compares the share price (convertToAssets(1e18)) to the last-settled reference and, on a move beyond maxNavDeviationBps, auto-pauses before any pending membership change can run. The reference resets on unpause so a resolved deviation cannot re-trip. Two decisions: the breaker pauses and returns rather than reverting, because a revert would roll back the pause (the pattern BoringVault's Accountant uses); and the default band is 50%, sized to catch an implausible jump (a constituent doubling) while tolerating severe real volatility so it does not false-trip and train operators to reflexively unpause. 10 new tests, 159 total green.
feat(vault): NAV circuit breaker and guardian pause (Section 4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.