Feat/constituent governance#13
Merged
Merged
Conversation
The deploy now builds and wires the ConstituentGovernor as part of the standard flow, closing the gap where the vault was left on the seed-only setConstituents with no governor. Seed constituents, deploy the governor (owned by the final OWNER from construction since it needs no deploy-time owner calls), call setGovernor (which locks the seed setter), then hand the five deployer-owned contracts to OWNER. Result: one governance authority over registry, oracle, methodology, vault, excluded-address registry, and governor, with GUARDIAN the single guardian for both the oracle pause and the governor veto. All contracts are Ownable2Step, so OWNER must acceptOwnership on each; documented in the header. Verified end-to-end on a mainnet fork.
…ght params setWeightParams moves every weight in the index the instant it is called and had no delay. Deploy a dedicated OZ TimelockController (proposer + executor = OWNER, self-administered with admin = address(0)) and own the methodology by it from construction, so a weight-param change is a delayed, publicly visible operation the multisig schedules through the timelock. The methodology ships with the intended defaults (25% cap target, 30% trigger, 1bp floor), so no deploy-time owner call is needed and there is no Ownable2Step accept dance for it; to change them, schedule setWeightParams through the timelock. Operational knobs on the other contracts stay on the fast multisig path. Verified end-to-end on a mainnet fork.
refactor(governance): consolidate the governance surfaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.