Skip to content

Cleaning #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seenamoshiri wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Cleaning #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ed3dcb7
Makes code a bit cleaner and more readable
seenamoshiri Oct 28, 2021
ed5aa61
Removes unused 'import' statements
seenamoshiri Oct 28, 2021
2b816be
Fixes typo mistakes with print (Capital P)
seenamoshiri Oct 28, 2021
d37fdda
Removes irrelevant comments
seenamoshiri Oct 28, 2021
5d3f5ec
Changes default value for IP, USERNAME, PASSWORD
seenamoshiri Oct 28, 2021
0a9fd17
Removes unused import and from statements from GET_OBJECTS.py
seenamoshiri Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions FMC_Functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
def GET_AUTH_TOKEN(IP,USERNAME,PASSWORD):
import json
import sys
import requests
server = "https://"+IP
Expand Down Expand Up @@ -37,8 +36,9 @@ def GET_DOMAIN_UUID(IP,AUTH_TOKEN):
if (status_code == 200):
#print("GET successful. Response data --> ")
json_resp = json.loads(resp)
domain_uuid=json_resp["items"][0]["uuid"]
domain_name=json_resp["items"][0]["name"]
domain = json_resp["items"][0]
domain_uuid = domain["uuid"]
domain_name = domain["name"]
return domain_name,domain_uuid
else:
r.raise_for_status()
Expand Down Expand Up @@ -78,7 +78,6 @@ def GET_ACP_LIST(IP,DOMAIN_UUID,TOKEN_ID):
##########################################################################################################################
def GET_ACCESSRULE_LIST(IP,DOMAIN_UUID,TOKEN_ID,ACCESS_POLICY_ID):
import json
import sys
import requests
server = "https://"+IP
ACP_ID=ACCESS_POLICY_ID
Expand Down Expand Up @@ -108,7 +107,6 @@ def GET_ACCESSRULE_LIST(IP,DOMAIN_UUID,TOKEN_ID,ACCESS_POLICY_ID):
##########################################################################################################################
def GET_ACCESSRULE_DETAIL(IP,DOMAIN_UUID,TOKEN_ID,ACCESS_POLICY_ID,RULE_ID):
import json
import sys
import requests
server = "https://"+IP
ACP_ID=ACCESS_POLICY_ID
Expand Down Expand Up @@ -140,7 +138,6 @@ def GET_ACCESSRULE_DETAIL(IP,DOMAIN_UUID,TOKEN_ID,ACCESS_POLICY_ID,RULE_ID):
def GET_OBJ_NETWORKS(IP,DOMAIN_UUID,TOKEN_ID,TYPE):
# type variable could be 4 values : hosts,networks,networkaddresses(includes hosts and networks),ranges
import json
import sys
import requests
r = None
server="https://"+IP
Expand Down Expand Up @@ -170,7 +167,6 @@ def GET_OBJ_NETWORKS(IP,DOMAIN_UUID,TOKEN_ID,TYPE):
def GET_NETWORKS_GROUPS(IP,DOMAIN_UUID,TOKEN_ID):
# type variable could be 4 values : hosts,networks,networkaddresses(includes hosts and networks),ranges
import json
import sys
import requests
r = None
server="https://"+IP
Expand Down
18 changes: 5 additions & 13 deletions GET_OBJECTS.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,11 @@
from FMC_Functions import GET_ACP_LIST
from FMC_Functions import GET_ACCESSRULE_LIST
from FMC_Functions import GET_ACCESSRULE_DETAIL
from FMC_Functions import GET_AUTH_TOKEN
from FMC_Functions import GET_DOMAIN_UUID
from FMC_Functions import GET_OBJ_NETWORKS
from FMC_Functions import GET_NETWORKS_GROUPS
import time
## Main program ##
import json
SERVER_IP="172.16.71.21"
#comment for credentials
##another edit for credentials
#also another comment
USERNAME="admin"
PASSWORD="P@ssw0rd"
SERVER_IP="SERVER_IP"
USERNAME="SERVER_USERNAME"
PASSWORD="SERVER_PASSWORD"
#Generate Token
token=GET_AUTH_TOKEN(SERVER_IP,USERNAME,PASSWORD)
print(token)
Expand All @@ -32,7 +24,7 @@
"value" : item["value"],
})

Print("List of Network Objects(JSON Format) : ")
print("List of Network Objects(JSON Format) : ")
for i in OBJECT_DETAIL_LIST:
print(i)
###########################################################
Expand All @@ -52,7 +44,7 @@
"value" : item["objects"],

})
Print("List of Network group Objects(JSON Format) : ")
print("List of Network group Objects(JSON Format) : ")
for item in GROUP_OBJ_DETAIL_LIST:
print(item)
print("###############")
Expand Down