Skip to content

Full refactor#84

Open
Sorrento110 wants to merge 15 commits into
devfrom
full_refactor
Open

Full refactor#84
Sorrento110 wants to merge 15 commits into
devfrom
full_refactor

Conversation

@Sorrento110

Copy link
Copy Markdown

Files split, docker cleaned up.

Working currently on time normalization cleanup. Using function in new time_processor.py to accomplish this as well as changing functions in normalizer.py to simplify. remove assoc objects and collapse the segregation of primary vs non primary time entries in the date dictionary.

Next step in refactor is to change the geo normalization code to be simplified.

Added 0 to 1 normalization code but it is not used in the normalizer. There is the potential to use this code separately from the regular data normalizer as a "last step" which is still undecided.

@brandomr

brandomr commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

@Sorrento110 you should definitely update the zero_to_one_normalizer.py file to use this code since it is way, way faster.

I also think we should consider changing the terminology a bit since now when we talk about normalization we mean two things:

  • structural normalization
  • feature scaling to 0 to 1

Maybe the latter should just be called feature_scaling.py and whenever we refer to it we always talk about "scaling" not normalizing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants