Skip to content

Carry native encoder context through analysis replay#80

Closed
FBartos wants to merge 11 commits into
jasp-stats:masterfrom
FBartos:bridge/jasp-syntax-integration
Closed

Carry native encoder context through analysis replay#80
FBartos wants to merge 11 commits into
jasp-stats:masterfrom
FBartos:bridge/jasp-syntax-integration

Conversation

@FBartos

@FBartos FBartos commented May 27, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR updates jaspTools as the orchestration layer for source-module analysis replay:

  • keeps the existing runAnalysis(..., verbose = ...) controls for separating analysis diagnostics from Desktop/QML/native chatter
  • stores the opaque jaspSyntax/SyntaxInterface column encoder context when a dataset is preloaded from a .jasp file or source dataset
  • passes that context into decodeAnalysisResults() so result replay uses the dataset/QML provenance that produced the analysis
  • removes the old preloaded column-mapping plumbing; jaspTools no longer performs or transports R-side decoding maps
  • preserves jaspTools as a thin bridge: it resolves inputs, runs the analysis, and forwards the captured context to jaspSyntax/jaspBase

Why

Encoding and decoding should be invisible to module authors and test authors. The lower-level PRs make Desktop the source of truth for token replacement; jaspTools only needs to keep the captured context attached to replay so old .jasp files and source-module tests decode the same way JASP would.

Related PRs

Validation

  • focused jaspTools lifecycle tests passed: test-jaspSyntax-lifecycle.R (133 pass, 3 gated real-Descriptives skips)
  • focused jaspBase tests passed: test-result-object-decoding.R, test-runWrappedAnalysis.R
  • focused jaspSyntax tests passed against the rebuilt local Desktop bridge: test-desktop-jasp-contract.R, test-dataset-helpers.R
  • R parse check passed
  • git diff --check

@FBartos FBartos requested a review from vandenman May 27, 2026 07:52
@FBartos FBartos changed the title Add runAnalysis verbosity levels Carry native encoder context through analysis replay Jun 3, 2026
@FBartos

FBartos commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Closing this wrong-base duplicate. The jaspTools bridge PR targeting development is #79: #79

@FBartos FBartos closed this Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants