Skip to content

Style editorial shell, entry layout, and webfonts#104

Open
jasonhnd wants to merge 1 commit into
mainfrom
codex/issue-103-editorial-draft-b
Open

Style editorial shell, entry layout, and webfonts#104
jasonhnd wants to merge 1 commit into
mainfrom
codex/issue-103-editorial-draft-b

Conversation

@jasonhnd

Copy link
Copy Markdown
Owner

Closes #103

Summary

  • Refines the shared shell with an editorial masthead, localized wide-screen subtitle, Home / Domains / Browse / AI nav, underline active state, and a quieter footer.
  • Replaces the entry factbar with an evidence strip for confidence, updated date, review-by, source count, machine badge, and original-language link.
  • Reduces the left entry rail to the current domain group plus an All domains link, removing per-page all-domain counts.
  • Self-hosts Source Serif 4 and Inter with OFL licenses, Latin / Latin-ext woff2 subsets, font-display: swap, fallback metrics, and CJK system-font fallback.
  • Updates the UI/UX contract doc for the new masthead and evidence-strip class contract.

Webfont Loading

  • Families loaded: 2 (Source Serif 4, Inter). CJK remains system font through Latin / Latin-ext unicode-range only.
  • Source Serif 4: 600 only, Latin 21,532 B (the only preloaded file) + Latin-ext 18,376 B.
  • Inter: variable 400-700, Latin 48,256 B + Latin-ext 85,068 B.
  • Total woff2 payload present: 173,232 B / 169.2 KiB. Only source-serif-4-latin-600.woff2 is preloaded.

Contrast Checks

  • Light: body 15.38:1, secondary 7.96:1, muted metadata 4.50:1, rust accent 6.02:1, teal link 6.96:1.
  • Dark: body 16.26:1, secondary 11.82:1, muted metadata 7.08:1, amber accent 8.30:1, teal link 10.43:1.

Validation

  • bun run build from site/ passed; 4,435 pages built.
  • bun run html:check passed: duplicate_id_pages=0, duplicate_ids=0.
  • bun run docs:audit passed.
  • bun tools/release.ts --check --strict passed.
  • bun run i18n:status passed: ja/zh/en stale=0.
  • bun tools/wiki_link_audit.ts --fail-on-issues passed: issues=0.
  • git diff --check passed.
  • Temporary Playwright visual smoke passed 12/12 on /, /ja/, /en/, /zh/, /ja/banking/sony-bank/, and /ja/banking/japan-net-bank-deposit-feature-matrix-2026/ across 1440px desktop and 390px mobile. Checks covered no page-level horizontal overflow, shell controls, active nav, evidence strip, left rail count removal, visible TOC, and CJK body font not using Inter.

Scope Notes

  • No corpus, generated surfaces, home page, or domain page files changed.
  • No CONTRIBUTING.md added.

@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
finwiki Ready Ready Preview, Comment Jun 25, 2026 5:38am

Request Review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f07f913f87

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

|---|---|---|
| Theme tokens | `global.css` defines light tokens in `:root` and dark overrides in `[data-theme="dark"]`. | Existing cool-neutral / teal-blue direction, readable light/dark contrast, token-first color changes. |
| Header shell | `Base.astro` renders `.site-header`, `.site-nav`, `.header-tools`, Pagefind trigger, `ThemeToggle`, `LangSwitcher` and footer. | Sticky compact header, skip link, localized navigation, Pagefind modal wiring, no overlap at narrow widths. |
| Header shell | `Base.astro` renders `.site-header`, editorial `.brand` masthead with localized subtitle, `.site-nav`, `.header-tools`, Pagefind trigger, `ThemeToggle`, `LangSwitcher` and footer. | Sticky compact header, skip link, Home / Domains / Browse / AI navigation with underline active state, Pagefind modal wiring, no overlap at narrow widths. |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required CHANGELOG entry

This commit updates the UI/UX functional spec and the shell/entry layout, but the diff does not include CHANGELOG.md; /workspace/finwiki/AGENTS.md requires: “When modifying content, structure, indexes, sync status, release status, or operating rules, CHANGELOG.md must be updated within the same work session.” Without that timeline entry, the required work log for this structural UI change is missing, so add the detailed changelog record for scope, validation, and follow-ups before merging.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI/UX] Human-site editorial Draft B — shell, entry layout & webfonts (#23, per #98 spec)

1 participant