Style editorial shell, entry layout, and webfonts#104
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f07f913f87
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| |---|---|---| | ||
| | Theme tokens | `global.css` defines light tokens in `:root` and dark overrides in `[data-theme="dark"]`. | Existing cool-neutral / teal-blue direction, readable light/dark contrast, token-first color changes. | | ||
| | Header shell | `Base.astro` renders `.site-header`, `.site-nav`, `.header-tools`, Pagefind trigger, `ThemeToggle`, `LangSwitcher` and footer. | Sticky compact header, skip link, localized navigation, Pagefind modal wiring, no overlap at narrow widths. | | ||
| | Header shell | `Base.astro` renders `.site-header`, editorial `.brand` masthead with localized subtitle, `.site-nav`, `.header-tools`, Pagefind trigger, `ThemeToggle`, `LangSwitcher` and footer. | Sticky compact header, skip link, Home / Domains / Browse / AI navigation with underline active state, Pagefind modal wiring, no overlap at narrow widths. | |
There was a problem hiding this comment.
Add the required CHANGELOG entry
This commit updates the UI/UX functional spec and the shell/entry layout, but the diff does not include CHANGELOG.md; /workspace/finwiki/AGENTS.md requires: “When modifying content, structure, indexes, sync status, release status, or operating rules, CHANGELOG.md must be updated within the same work session.” Without that timeline entry, the required work log for this structural UI change is missing, so add the detailed changelog record for scope, validation, and follow-ups before merging.
Useful? React with 👍 / 👎.
Closes #103
Summary
font-display: swap, fallback metrics, and CJK system-font fallback.Webfont Loading
Source Serif 4,Inter). CJK remains system font through Latin / Latin-extunicode-rangeonly.source-serif-4-latin-600.woff2is preloaded.Contrast Checks
Validation
bun run buildfromsite/passed; 4,435 pages built.bun run html:checkpassed:duplicate_id_pages=0,duplicate_ids=0.bun run docs:auditpassed.bun tools/release.ts --check --strictpassed.bun run i18n:statuspassed: ja/zh/en stale=0.bun tools/wiki_link_audit.ts --fail-on-issuespassed: issues=0.git diff --checkpassed./,/ja/,/en/,/zh/,/ja/banking/sony-bank/, and/ja/banking/japan-net-bank-deposit-feature-matrix-2026/across 1440px desktop and 390px mobile. Checks covered no page-level horizontal overflow, shell controls, active nav, evidence strip, left rail count removal, visible TOC, and CJK body font not using Inter.Scope Notes
CONTRIBUTING.mdadded.