test(grey-state): add proptests for accumulate sub-transition#826
test(grey-state): add proptests for accumulate sub-transition#826wangzishuai1987 wants to merge 2 commits into
Conversation
Add property-based tests for the accumulate module's pure functions: - decode_preimage_info_timeslots: roundtrip and no-panic properties - compute_dependencies: no duplicates, includes all prerequisites - partition_reports: total count, no-deps=immediate, with-deps=queued - edit_queue: no accumulated entries/deps survive editing - resolve_queue: empty and all-zero-deps properties - find_free_service_id: result not in accounts, above threshold - encode_accumulate_args: fixed length and deterministic - compute_output_hash: deterministic, order-independent, sensitive Refs: jarchain#229
Genesis ReviewComparison targets:
How to reviewPost a comment with the following format (rank from best to worst): Use the short commit hashes above and To meta-review another reviewer's comment, react with 👍 or 👎. |
|
/review Adds broad property coverage for accumulate queue/dependency helpers, service ID selection, argument encoding, and output hash determinism/order independence. It ranks below the GRANDPA persistence fix and interpreter dispatch refactor, but above smaller state/type/doc coverage because accumulate has a larger behavioral surface. Merge is reasonable as targeted state-transition test coverage. |
|
JAR Bot: Review recorded from @johandroid (1 reviews, 0 meta-reviews). |
Summary
Adds property-based tests for the accumulate sub-transition's pure functions (Section 12):
decode_preimage_info_timeslots:
compute_dependencies:
partition_reports:
edit_queue:
resolve_queue:
find_free_service_id:
encode_accumulate_args:
compute_output_hash:
Refs: #229