test(grey-merkle): add proptests for trie root properties#823
Open
wangzishuai1987 wants to merge 2 commits into
Open
test(grey-merkle): add proptests for trie root properties#823wangzishuai1987 wants to merge 2 commits into
wangzishuai1987 wants to merge 2 commits into
Conversation
Add property-based tests for the binary Patricia Merkle trie: - Root is deterministic (same KVs → same root) - Root is order-independent (shuffled KVs → same root) - Root changes when any value is modified - Root changes when a key is added or removed - Root is non-zero for non-empty trie - Single-entry trie matches corresponding leaf node hash - TrieNode encoding is deterministic Refs: jarchain#229
Contributor
Genesis ReviewComparison targets:
How to reviewPost a comment with the following format (rank from best to worst): Use the short commit hashes above and To meta-review another reviewer's comment, react with 👍 or 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds property-based tests for the binary Patricia Merkle trie (Appendix D.2):
Refs: #229 (Merkle tree properties — "Root changes when any leaf changes")