refactor: add missing Copy derive to small value types#818
Open
wangzishuai1987 wants to merge 1 commit into
Open
refactor: add missing Copy derive to small value types#818wangzishuai1987 wants to merge 1 commit into
wangzishuai1987 wants to merge 1 commit into
Conversation
Contributor
Genesis ReviewComparison targets:
How to reviewPost a comment with the following format (rank from best to worst): Use the short commit hashes above and To meta-review another reviewer's comment, react with 👍 or 👎. |
Several structs/enums have all-Copy fields but only derive Clone, forcing unnecessary heap allocations when only Copy semantics are needed: - ExitReason (javm): all variants are no-data or u32 - ServiceInfo (grey-state): Hash + Gas, both Copy - CoreStats (grey-state): eight u64 fields - ReportedPackage (grey-state): two Hash fields No behavior changes — pure refactoring. Contributes to jarchain#186.
wangzishuai1987
force-pushed
the
refactor/add-missing-copy-derive
branch
from
1d742d3 to
f8662e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contributes to #186 — eliminate code duplication and improve type ergonomics.
Several structs and enums have all-Copy fields but only derive
Clone, forcing unnecessary clones whenCopysemantics would suffice.Changes
ExitReasonCopyServiceInfoHash+Gas(both Copy)CopyCoreStatsu64fieldsCopyReportedPackageHashfieldsCopyTesting
Compiles cleanly. No behavior changes — pure refactoring.