Replace production unwrap() with descriptive expect() messages#817
Open
wangzi111333 wants to merge 1 commit into
Open
Replace production unwrap() with descriptive expect() messages#817wangzi111333 wants to merge 1 commit into
wangzi111333 wants to merge 1 commit into
Conversation
Replace bare unwrap() calls in non-test production code with expect() that provides context for debugging if the unlikely panic occurs: - grey-rpc: 4 HTTP response construction + 1 mutex lock - grey/node: 2 SystemTime + pending block lookup - grey/main: 1 SystemTime (genesis time) - javm/kernel: 2 cap.split() calls - grey-erasure: 1 originals collection Refs jarchain#186.
Contributor
Genesis ReviewComparison targets:
How to reviewPost a comment with the following format (rank from best to worst): Use the short commit hashes above and To meta-review another reviewer's comment, react with 👍 or 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace bare
unwrap()calls in non-test production code withexpect()that provides context for debugging:cap.split()after bounds checksall(Some)checkAll of these were infallible by construction, but
expect()makes the invariant explicit and provides a useful message if violated.Refs #186