opt(interpreter): use feed_direct() in compute_block_gas_costs()#813
Open
liuyiyi185 wants to merge 1 commit into
Open
opt(interpreter): use feed_direct() in compute_block_gas_costs()#813liuyiyi185 wants to merge 1 commit into
liuyiyi185 wants to merge 1 commit into
Conversation
Fast path for ~90% of instructions (loads, stores, ALU, immediates, terminators) via GasSimulator::feed_direct(), which takes register indices directly and avoids constructing a FastCost struct. Only instructions requiring context-dependent cost computation (ecalli, load_imm_jump, conditional branches 181..=255, and unrecognised opcodes) fall back to fast_cost_from_raw() + feed(). Closes jarchain#812
Contributor
Genesis ReviewComparison targets:
How to reviewPost a comment with the following format (rank from best to worst): Use the short commit hashes above and To meta-review another reviewer's comment, react with 👍 or 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the ast_cost_from_raw() + sim.feed(&fc) path in
compute_block_gas_costs() with a direct sim.feed_direct() fast path
for ~90% of instructions.
Changes
constructs a FastCost struct with bitmask arithmetic, trailing_zeros
extraction, etc.) and then sim.feed(&fc).
context-free terminators) call sim.feed_direct(cycles, slots, src1, src2, dst)
directly with raw register nibbles - no struct allocation, no bitmask ops.
Only instructions that genuinely require context-dependent cost computation
(ecalli 10, load_imm_jump 80, conditional branches 181..=255, and
unrecognised opcodes) fall back to the full ast_cost_from_raw() + eed().
Performance Impact
one-time pre-decode path, but also hits Interpreter::predecode() used
by CODE cap construction
Testing
to produce the same result as eed(&FastCost{...}) by the
eed_matches_feed_direct proptest in gas_sim.rs
Related
Closes #812 - optimize javm interpreter performance (#400)