Fixes to invertSVD function in fishermatrix.py#112
Merged
Conversation
bhuyan-g
commented
Apr 20, 2026
bhuyan-g
left a comment
bhuyan-g
left a comment
Contributor
Author
There was a problem hiding this comment.
This fixes the errors thrown by invertSVD function in the fishermatrix.py.
Collaborator
|
Looks good to me! |
u-dupletsa
approved these changes
Apr 20, 2026
u-dupletsa
left a comment
u-dupletsa
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me as well! Thanks for the improvement!
Contributor
Author
|
Thanks for reviewing and approving the pull request. It's my firstsuch
contribution to a major project in GW astronomy.
Cheers!!
Gautam
===================================================
With warm regards
Gautam Bhuyan
Research Scholar
Department of Physics
Cotton University, Guwahati-781001
Assam, India
Ph.# : +91-6000454671
https://bhuyan-g.github.io/gautambhuyan.github.io/
===================================================
…On Mon, 20 Apr, 2026, 2:48 pm Ulyana Dupletsa, ***@***.***> wrote:
Merged #112 <#112> into main.
—
Reply to this email directly, view it on GitHub
<#112?email_source=notifications&email_token=ALNAXDLORWMWLI2Y6RHI56D4WXTNNA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTENBWG4YDENJXGEZDLJTSMVQXG33OUZQXK5DIN5ZKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#event-24670257125>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALNAXDKT56R6ZA7DPJ5MQCL4WXTNNAVCNFSM6AAAAACX7I7YECVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRUGY3TAMRVG4YTENI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The earlier version of invertSVD function in
fishermatrix.pywas throwingSVD did not convergeerror. This version works around that error to keep a population analysis running.