v1.0.10#26
Merged
Merged
Conversation
This pull request introduces a new feature that allows users to toggle the visibility of the assistant's reasoning (internal thought process) in the TUI using a keyboard shortcut (Ctrl+K). It adds an animated placeholder when reasoning is hidden, provides localized status messages and help text, and includes comprehensive tests for the new functionality. The changes also ensure that the UI and state are properly updated when toggling reasoning visibility or during request cycles. **New Reasoning Visibility Feature:** * Added a new `reasoningExpanded` state and related logic to the `model` in `internal/tui/model.go` to control whether the assistant's reasoning is shown or hidden, with animated placeholder support when hidden. [[1]](diffhunk://#diff-8f28281a6c168ae2186228c5ff4fa00c1c8e2b0d4c2c863197acffcec7363eedR315-R316) [[2]](diffhunk://#diff-8f28281a6c168ae2186228c5ff4fa00c1c8e2b0d4c2c863197acffcec7363eedL1247-R1354) [[3]](diffhunk://#diff-8f28281a6c168ae2186228c5ff4fa00c1c8e2b0d4c2c863197acffcec7363eedL1234-R1239) * Implemented the `toggleReasoningView` method and integrated it with the Ctrl+K keyboard shortcut in `internal/tui/update.go`, allowing users to toggle reasoning visibility. [[1]](diffhunk://#diff-8f28281a6c168ae2186228c5ff4fa00c1c8e2b0d4c2c863197acffcec7363eedR1557-R1576) [[2]](diffhunk://#diff-0cf542d3da611ed1496ddd6dcdc5b150c81a56fe8032e474fc870782858178fbR155-R156) * Updated the key binding tokens to include Ctrl+K in help overlays in `internal/tui/view.go`. * Modified help text in both English and Spanish translations to document the new shortcut, and added localized status messages and placeholders for reasoning. [[1]](diffhunk://#diff-ded853fd7b219208693f40eb660ccb9f284eb7d89987782ab5278b5230e883c4L41-R41) [[2]](diffhunk://#diff-ded853fd7b219208693f40eb660ccb9f284eb7d89987782ab5278b5230e883c4R110-R114) [[3]](diffhunk://#diff-7af7a8358c5de3824053776aed625d17ed88ecb1bd7254193e599771ab61cca0L41-R41) [[4]](diffhunk://#diff-7af7a8358c5de3824053776aed625d17ed88ecb1bd7254193e599771ab61cca0R110-R114) **UI/State Management Improvements:** * Ensured that the reasoning pulse animation resets appropriately during conversation clearing, request start, and request finish events. [[1]](diffhunk://#diff-8f28281a6c168ae2186228c5ff4fa00c1c8e2b0d4c2c863197acffcec7363eedR653) [[2]](diffhunk://#diff-8f28281a6c168ae2186228c5ff4fa00c1c8e2b0d4c2c863197acffcec7363eedR2164) [[3]](diffhunk://#diff-0cf542d3da611ed1496ddd6dcdc5b150c81a56fe8032e474fc870782858178fbR640) * Added logic to advance the reasoning pulse animation in sync with streamed assistant output. **Testing:** * Added comprehensive tests for toggling reasoning visibility and for the reasoning pulse animation in `internal/tui/slash_input_test.go`. **Other:** * Minor adjustment to a test for viewport height to allow for increased flexibility in UI rendering. These changes collectively enhance the user experience by giving users control over the display of assistant reasoning, improving accessibility, and ensuring robust behavior through testing.
This pull request introduces a slash command autocomplete feature in the TUI, allowing users to easily discover and select available slash commands with descriptions as they type. To support this, the slash command configuration and YAML schema are extended to include a desc (description) field, and the UI is updated to display a floating autocomplete box with command names and their descriptions. Several code changes ensure the new field is handled throughout configuration loading, normalization, and rendering.
This pull request introduces a built-in /help slash command and a modal-based help system to the TUI, along with related improvements to keyboard shortcuts, translations, and test coverage.
This pull request introduces support for user feedback on search results and enhances the search service with domain reputation adjustments. It also improves internationalization with new translations, adds new dependencies, and refactors the search and TUI models to support feedback and reputation features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a user feedback loop to the
/searchfeature, allowing users to vote on search results and have their preferences influence future search rankings. It also adds descriptions to slash commands for improved help and discoverability, and updates documentation and translations to reflect these enhancements. Several new dependencies are included to support the feedback system and related features.User Feedback and Search Ranking Improvements
/search: users can vote on results withCtrl+Up(useful) andCtrl+Down(not useful); votes are stored in a local SQLite database and are used to rerank future results based on domain reputation and recent feedback. The query rewriter also uses positive examples from feedback to improve future queries. Documentation and workflow diagrams have been updated to explain the feedback system and its technical implementation. [1] [2] [3] [4]Slash Command and Help Improvements
desc(description) field to theSlashCommandstruct, configuration, and YAML loading logic, allowing each slash command to have a user-facing description for help and autocomplete. [1] [2] [3] [4] [5] [6]Dependency Updates
go.modto support SQLite, time-based decay, and other features required for the feedback loop (modernc.org/sqlite,modernc.org/libc,modernc.org/mathutil,modernc.org/memory,github.com/dustin/go-humanize,github.com/ncruces/go-strftime,github.com/remyoudompheng/bigfft,golang.org/x/exp). [1] [2] [3] [4]Internal Search Pipeline Enhancements