Add tests for clojure.core/list#915
Open
brandoncorrea wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new clojure.core/list test namespace to close issue #336, expanding the core collection constructor coverage alongside existing vector tests.
Changes:
- Introduces
clojure.core-test.listwithwhen-var-exists-guarded tests forlist - Covers empty, single/multiple element construction, nested structures, duplicates, larger arities, and mixed-type lists
- Uses
areto reduce repetition and keep assertions compact
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #336.
These tests were heavily inspired by its
vectorcounterpart: https://github.com/jank-lang/clojure-test-suite/blob/main/test/clojure/core_test/vector.cljc.Differences from
vectorTestsareover repeatedislist?checks in various tests(list '())testintooperation from large lists(= (range 100) coll)(should) works with either vectors or listsintoworking properly (or at all)Aligning
vectorandlisttestsI think it would be valuable to align the structure of these two tests. I can make those changes in this PR, or create a follow-up PR that aligns the two.