fix(chat): ignore custom SSE event types in OpenAI-compatible streams#8392
Open
qnixsynapse wants to merge 1 commit into
Open
fix(chat): ignore custom SSE event types in OpenAI-compatible streams#8392qnixsynapse wants to merge 1 commit into
qnixsynapse wants to merge 1 commit into
Conversation
The AI SDK's parseJsonEventStream validates every SSE data line against the chat.completion.chunk schema, discarding the event: type. Servers that interleave custom named events (e.g. event: hermes.tool.progress) tripped a fatal 'Type validation failed' that aborted the whole stream. Filter non-default SSE events out of the byte stream in createCustomFetch before the SDK parses it, per the W3C spec (clients ignore unhandled event types).
Contributor
Barecheck - Code coverage reportTotal: 50.62%Your code coverage diff: 0.04% ▴ Uncovered files and lines
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Filter non-default SSE events out of the byte stream in createCustomFetch before the SDK parses it, per the W3C spec (clients ignore unhandled event types).
Fixes Issues
Self Checklist