Run only react-arborist unit tests in release script#335
Merged
TrevorBurnham merged 1 commit intoMay 10, 2026
Conversation
`yarn test` at the root expands to `workspaces foreach --all run test`, which includes the e2e module. e2e boots a static showcase server and runs Cypress — it requires a prior `next build`, a browser, and is much slower than unit tests. It also hangs silently when the showcase static output isn't built. E2e tests aren't a release gate (the Build & Test PR workflow runs them on every PR). The release script only needs to verify the library being released still passes its own unit tests.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root
yarn testisworkspaces foreach --all run test, which includes thee2emodule.e2e's test command boots a static showcase server (serve ./out) and runs Cypress against it. Two problems for the release flow:next buildof the showcase, otherwiseservehangs silently (> /dev/nullswallows the error).yarn release minorgot stuck here.Build & TestPR workflow runs them on every PR.Change
Scope the release-time test step to
yarn workspace react-arborist testso it only runs the library's unit tests.Test plan
yarn release minor --preview --any-branchruns jest only and completes