fix: resolve all CI warnings and compilation errors#5
Merged
Conversation
jafreck
force-pushed
the
fix/ci-warnings
branch
2 times, most recently
from
302faf8 to
ae01bc6
Compare
- Remove unused imports (TensorData, HashMap, MemoryUsage, ActivationHook, LayerSchedulePass) - Remove unnecessary parentheses in closures and block return values - Fix unused/unnecessary mut bindings (onnx_model, func) - Prefix unused variables with underscore (pre, manifest, max_seq_len) - Fix QuantizationInfo missing import in bundle.rs tests - Replace tautological u8 <= 255 assertion with non-empty check - Replace tautological u64 >= 0 assertion with acknowledgement - Mark test-only reconstruction_mse as #[allow(dead_code)] - Fix doc test missing type imports in burn-coreml and candle-coreml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes all warnings and errors from CI run #179:
Compilation errors (3):
QuantizationInfoimport inbundle.rstestsWarnings fixed (16):
TensorData,HashMap,MemoryUsage,ActivationHook,LayerSchedulePassmutbindings (onnx_model,func)pre,manifest,max_seq_len)u8 <= 255assertion with non-empty checku64 >= 0assertionreconstruction_mseas#[allow(dead_code)]