optimze region creation#111
Open
jacob314 wants to merge 1 commit into
Open
Conversation
jacob314
force-pushed
the
optimze_blank2
branch
from
9131892 to
8021cfa
Compare
Update snapshot for scroll-blue-background Update snapshot for scroll-demo.sticky-on Update SVG snapshot for scroll-blue-background Fix terminal-buffer linesOffsetY and scrollToBackbuffer issues Optimize IPC by trimming leading/trailing empty lines in diffs Fix flaky scroll integration test fix(terminal-buffer): only skip leading empties if old line was also empty Update scroll snapshots reflecting fixed sticky header behavior Fix garbled text on naturally scrolling headers
jacob314
force-pushed
the
optimze_blank2
branch
from
f89ae00 to
b80c5c5
Compare
jacob314
commented
Apr 10, 2026
| │2 This is line in a line in a box. This is some text that is long enough to require some word wrapping. │ | ||
| │3 This is line in a line in a box. This is some text that is long enough to require some word wrapping. │ | ||
| │4 This is line in a line in a box. This is some text that is long enough to require some word wrapping. │ | ||
| │This is the first line of box 0 with yellow text. │ █ |
Owner
Author
There was a problem hiding this comment.
content is the same except now the scrollbar is visible when before it was missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce memory usage by handling region where most of the lines are empty more efficiently.
We were creating large almost completely empty boxes for common layouts with an enormous box that scrolls to the backbuffer with multiple regions inside it each corresponding to a static item.
This resulted in unneeded lines and a lot of wasted work comparing those lines.