refactor: simplify StaticRender layout computation#105
Open
jacob314 wants to merge 5 commits into
Open
Annotations
10 errors and 1 warning
|
Run npm test -- --serial:
src/worker/scene-manager.ts#L115
Replace `update.lines.contentShiftDelta·&&·update.lines.contentShiftDelta·>·0` with `⏎↹↹↹↹↹update.lines.contentShiftDelta·&&⏎↹↹↹↹↹update.lines.contentShiftDelta·>·0⏎↹↹↹↹`
|
|
Run npm test -- --serial:
src/terminal-buffer.ts#L704
Unexpected negated condition.
|
|
Run npm test -- --serial:
src/terminal-buffer.ts#L704
Replace `·contentShiftDelta·!==·0·?·contentShiftDelta·:·undefined` with `⏎↹↹↹↹contentShiftDelta·!==·0·?·contentShiftDelta·:·undefined,`
|
|
Run npm test -- --serial:
src/terminal-buffer.ts#L663
Replace `·oldIndex·>=·0·&&·oldIndex·<·oldLines.length·?·oldLines[oldIndex]·` with `⏎↹↹↹↹oldIndex·>=·0·&&·oldIndex·<·oldLines.length⏎↹↹↹↹↹?·oldLines[oldIndex]⏎↹↹↹↹↹`
|
|
|
|
|
|
Run npm test -- --serial:
src/terminal-buffer.ts#L633
Replace `linesEqual(oldLines[oldLines.length·-·i],·newLines[newLines.length·-·i])` with `⏎↹↹↹↹↹linesEqual(⏎↹↹↹↹↹↹oldLines[oldLines.length·-·i],⏎↹↹↹↹↹↹newLines[newLines.length·-·i],⏎↹↹↹↹↹)⏎↹↹↹↹`
|
|
|
|
|
|
Run npm test -- --serial:
src/terminal-buffer.ts#L521
Replace `⏎↹↹↹last.lines,⏎↹↹↹current.lines,⏎↹↹` with `last.lines,·current.lines`
|
|
Complete job
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
background
wait
wait-all
cancel
parallel
Loading