Modifiable data path - #1
Open
jacob-rousseau wants to merge 2 commits into
Open
Conversation
…ded. Advantage is that confidentiallookup values can be stored more easily in a separate location which is not under the source directory structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hallo Vincent,
here is the pull request I mentioned yesterday in the mail. The reason for this modification is that the location of the lookup tables was tightly coupled and hardcoded in the source. By making it configurable you can more easily create a development and testing environment with specific lookup tables and a production environment. In the production enviroment you could have lookup lists with data from your EHR (HiX or EPIC).
The directory in the current config.json file (./data/lookup_lists) reproduces the previous situation and must be used for regression and unit-testing.
Although the tight-coupling of the directory could be considered valueable for reproduction/reproducability purposes, I considered the extra operational benifit as more valueable. Hopefully you agree with this and that you'll accept this pull request.
Regards, Jacob