Add CI workflow; improve DB config defaults#110
Merged
Conversation
Add a GitHub Actions CI pipeline and make DB connection config more robust. Files changed: - .github/workflows/ci.yml: new CI pipeline that runs on pushes and PRs, starts a MySQL 8.0 service, checks out code, sets up Node 20, installs deps, waits for MySQL, applies schema.sql, runs a basic app health check (curl on localhost:3000), and builds a Docker image. - app/services/db.js: broadened environment variable fallbacks and added sane defaults (host -> 127.0.0.1, port fallbacks incl. MYSQL_PORT, user default "root", password default "password", database default "tapthat-db"). Also increased pool connectionLimit from 2 to 10 to allow more concurrent DB connections. These changes add CI coverage and make local/CI DB configuration more fault-tolerant and better suited for concurrent workloads.
Adjust the GitHub Actions CI MySQL service: set MYSQL_ROOT_PASSWORD to 'root', add MYSQL_ROOT_HOST set to '%', and change the health check to ping 127.0.0.1 (TCP) instead of localhost. Also restore the missing trailing newline in the workflow file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a GitHub Actions CI pipeline and make DB connection config more robust.
Files changed:
These changes add CI coverage and make local/CI DB configuration more fault-tolerant and better suited for concurrent workloads.