refactor(ecdh): P-521 hygiene pass — hoist constants, BigInt literals, reformat#59
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jacaudi
added a commit
that referenced
this pull request
Apr 13, 2026
Empty commit to trigger semantic-release. The five refactor PRs that landed after v0.7.2 (buffer sharing, query-string parser rewrite, secureOverwriteBuffer simplification, doStuff/undoStuff unification, ECDH P-521 hygiene pass) use conventional commit types that don't bump the version, so this commit ships them as v0.7.3. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P521) out of thedetermineEcdhconstructor to module scope — no reason to rebuild the same 6 BigInts on every instantiationBigInt(N)calls toNnliteral syntax (e.g.BigInt(0)→0n) for numeric literals; leavesBigInt("0x...")hex strings andBigInt(seedView[i])runtime access untouchedsrc/js/worker/ecdh.jsfor 4-space indentation, consistent operator spacing, and one statement per lineZero algorithmic changes. A new determinism test (
app/tests/test-ecdh-determinism.js) pins the fixed-seedgenerateKeyPair(seed)output — private key and public point coordinates — and runs after every commit to catch accidental math drift from the reformat.Test plan
node --test app/tests/test-ecdh-determinism.jspasses after each of the 3 refactor commits?pub=URL🤖 Generated with Claude Code